Revert fetching config flow after subscribe for progress #18939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenck
approved these changes
Dec 7, 2023
7 tasks
|
I don't agree with this PR. #18775 fixed a fundamental flaw in the show progress functionality. |
20 tasks
20 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #18775
Breaking change
The original PR was created for home-assistant/core#71034, that will have a timing issue again.
Proposed change
This change, while technically probably correct, causes issues with flows, we are going to revert this for now, check all the config flows and fix them, and afterwards re-enable this.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: